gitpod-io / gitpod-io/gitpod

Hide unnecessary navigation elements on error page shown when users can not join a team

Open
#10,503 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component: dashboard meta: never-stale team: webapp type: bug
Dominant language
TypeScript
Stars
13.8k
Forks
1.4k
Avg merge
17h 58m
Merged PRs (30d)
5

Description

Bug description

Following up from https://github.com/gitpod-io/gitpod/pull/10309, when users trying to join a team and the invite URL has expired, the team menu on the navigation shows an extra empty element.

This is probably because of all the logical checks like https://github.com/gitpod-io/gitpod/pull/10309/files#diff-64248da95f399a1cfe99b03aa662caf313faf9b7016999111605da5d61f1971dR269.

There are possibly other pages that users could end up in this case. Maybe worth making the menu logic more explicit. 💭

1️⃣ (Deleted Team) 2️⃣ (Reset Invite URL) 3️⃣ (User Blocked) 4️⃣ (???)
Screenshot 2022-06-07 at 5 19 32 PM (2) Screenshot 2022-06-07 at 5 16 44 PM (2) Screenshot 2022-06-07 at 5 16 05 PM (2) Screenshot 2022-06-07 at 5 20 03 PM (2)
Steps to reproduce

Try joining a team after 1️⃣ deleting the team, 2️⃣ resetting the invite URL, 3️⃣ blocking the user, 4️⃣ etc.

Notice the 1 extra blank breadcrumb item and the 2 redundant tab menu below the team scope selector, which could be safely removed, see screenshot below.

Frame 1097

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the changes in pull request #10309, especially the referenced logical checks around line 269. Reproduce the expired, deleted-team, reset-invite, and blocked-user cases described in the issue. Done means the error page no longer shows blank breadcrumb items or redundant tab navigation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.