githubtraining / githubtraining/training-manual

Feedback please: Code quality checks of scripts

Open
#168 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
340
Forks
375
PR merge metrics
No merged PRs in 30d

Description

Running shellcheck to check the code quality of the scripts in the script directory result in over 580 code quality issues across 12 scripts. These issues can have unintended consequences that will result in problems with the execution of the various scripts.

[test.txt](https://github.com/githubtraining/training-manual/files/2793472/test.txt)
(rename test.txt to test or test.bash, make executable, run; requires shellcheck - See https://github.com/koalaman/shellcheck)

I'm willing to undertake this issue and resolve the code quality issues if it is considered valuable.

Feedback please.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.