githubnext / githubnext/gh-aw-test

Suggested test: copilot/submit-pull-request-review-commit-id

Open Beginner friendly
#9,966 0 comments 0 reactions 0 assignees View on GitHub
suggested new test
Dominant language
Shell
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

## Motivation

Link to the gh-aw PR: github/gh-aw#48738 — feat: add `commit-id` config option to pin review attribution to the reviewed commit

Under `workflow_run` triggers the safe-outputs step runs after the agent, so a new commit may land during the agent's run, causing the review to be attributed to the wrong commit SHA. The new `commit-id` field on `submit-pull-request-review` pins attribution to the intended commit.

## Proposed test

- **Workflow file**: `test-copilot-submit-pull-request-review-commit-id.md`
- **Trigger**: `workflow_dispatch`
- **Engine**: copilot
- **Safe output**: `submit-pull-request-review`
- **Variant**: standard

## Minimal test prompt sketch

Instruct the agent to fetch a known open PR in `githubnext/gh-aw-test`, capture its current HEAD SHA, and submit a COMMENT-type review pinned to that SHA via the `commit-id` field. The harness can verify the review was created and that the `commit_id` field on the GitHub review object matches the expected SHA.

## New fixtures or secrets needed

None — uses the existing `githubnext/gh-aw-test` repo and a pre-created test PR (same fixture pattern as `test-copilot-submit-pull-request-review.md`).

## Notes

`test-copilot-submit-pull-request-review.md` and `test-copilot-submit-pull-request-review-locked.md` already exist but neither exercises the `commit-id` config option. This is a new field that warrants a separate regression test to guard against the stale-commit attribution regression fixed in #48738.

> Generated by [🔍 Suggest New E2E Tests](https://github.com/githubnext/gh-aw-test/actions/runs/30439497125) · sonnet46 · 21.2 AIC · ⌖ 4.31 AIC · ⊞ 6.1K · [◷](https://github.com/search?q=repo%3Agithubnext%2Fgh-aw-test+is%3Aissue+%22gh-aw-workflow-call-id%3A+githubnext%2Fgh-aw-test%2Fsuggest-new-e2e-tests%22&type=issues)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start from test-copilot-submit-pull-request-review.md and test-copilot-submit-pull-request-review-locked.md, then create the proposed test-copilot-submit-pull-request-review-commit-id.md workflow using the existing githubnext/gh-aw-test PR fixture. Follow the workflow_dispatch, copilot, standard, and submit-pull-request-review pattern. It is done when the harness verifies the review was created and its commit_id matches the captured HEAD SHA.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, testing
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.