githubnext / githubnext/gh-aw-test

Suggested test: copilot/dismiss-pull-request-review-bot-author

Closed
#10,715 0 comments 0 reactions 0 assignees View on GitHub
[suggested new test] suggested new test
Dominant language
Shell
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

## Motivation

github/gh-aw#49648 — `dismiss_pull_request_review.cjs` now exempts bot accounts (`reviewAuthor.endsWith("[bot]")`) from the author-match guard, allowing a workflow to dismiss a review it authored as `github-actions[bot]` (previously rejected with "review author must match dismisser"). No existing test exercises `dismiss-pull-request-review` at all.

## Proposed test

- **Workflow file**: `test-copilot-dismiss-pull-request-review.md`
- **Trigger**: `workflow_dispatch` with `pull_request_number` and `review_id` inputs
- **Engine**: copilot
- **Safe output**: `dismiss-pull-request-review`
- **Variant**: standard

## Minimal test prompt sketch

Have the agent call `dismiss-pull-request-review` on a review previously left by the bot/token itself (created via a prior `submit-pull-request-review` step or pre-seeded), passing a dismissal message, and assert success rather than an author-mismatch error.

## New fixtures or secrets needed

Needs a PR with an existing bot-authored review to dismiss. Could self-seed within the workflow: create a throwaway PR + submit a review with `GH_AW_TEST_PAT`/default token, then dismiss it in the same run. Uses existing `GH_AW_TEST_PAT` secret; no new fixture repo required.

## Notes

Overlaps conceptually with `test-copilot-submit-pull-request-review.md` and `test-copilot-resolve-pull-request-review-thread.md` for setup patterns (self-seeding a PR/review via workflow_dispatch inputs). This is a distinct safe-output type with no current coverage.

> Generated by [🔍 Suggest New E2E Tests](https://github.com/githubnext/gh-aw-test/actions/runs/30741299903) · auto · 36.4 AIC · ⌖ 7.01 AIC · ⊞ 8.3K · [◷](https://github.com/search?q=repo%3Agithubnext%2Fgh-aw-test+is%3Aissue+%22gh-aw-workflow-call-id%3A+githubnext%2Fgh-aw-test%2Fsuggest-new-e2e-tests%22&type=issues)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the proposed test file test-copilot-dismiss-pull-request-review.md and compare setup patterns in test-copilot-submit-pull-request-review.md and test-copilot-resolve-pull-request-review-thread.md. Use workflow_dispatch inputs and the existing GH_AW_TEST_PAT or default token to create a bot-authored review. Done means the dismiss-pull-request-review safe output succeeds without an author-mismatch error.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, shell
Domain
ci-cd, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.