githubnext / githubnext/ado-aw

YAML generation uses manual string building in compile_gate_step_external

Open Beginner friendly
#384 0 comments 0 reactions 0 assignees View on GitHub
refactor rust
Dominant language
Rust
Stars
23
Forks
8
Avg merge
4d 9h
Merged PRs (30d)
22

Description

src/compile/filter_ir.rs:

step.push_str(&format!(" name: {}\n", ctx.step_name()));
step.push_str(&format!(" displayName: \"{}\"\n", ctx.display_name()));
These values come from &'static str constants so there's no injection risk today. But the pattern is fragile — a future GateContext variant with a display name containing " or \n would silently produce invalid YAML. Suggest serializing via serde_yaml or at minimum YAML-escaping display names.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review src/compile/filter_ir.rs and compile_gate_step_external, then compare the current manual YAML construction with the proposed serialization or escaping approach. Done means generated YAML remains valid when names contain quotes or newlines, without changing current output for the existing static names.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, devops
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.