github / github/vscode-github-actions

double curly brace can have incorrect syntax highlighting inside format within expression

Open
#394 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
660
Forks
213
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
When a double closing curly brace (`}}` is used as an escape to represent a single closing curly brace (`}`) inside a format function that is within an expression, it gets incorrectly colored as the end of the expression.

**To Reproduce**
Steps to reproduce the behavior:
1. With the workflow file below, open in vscode editor
2. View the syntax highlighting as incorrect. The first double closing curly brace on line 19 should not be yellow.

```
name: Double Curly Brace Workflow

on:
workflow_dispatch:
inputs:
something-to-print:
description: Something to print in powershell.
required: true
type: string

jobs:
double_curly_brace_job:
runs-on:
labels: windows

steps:
- name: Double Curly Brace Step
env:
VAR_WITH_DOUBLE_CURLY_BRACE: "${{ format('{{ {0} }}', inputs.something-to-print) }}"
run: |
echo "${{ env.VAR_WITH_DOUBLE_CURLY_BRACE }}"
```

**Expected behavior**
The last double closing curly brace should be yellow on line 19.

**Screenshots**
image

**Extension Version**
`v0.26.5`

**Additional context**
I am testing this on Mac OS Sonoma 14.5
`code --version
1.91.1
f1e16e1e6214d7c44d078b1f0607b2388f29d729
x64`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.