github / github/template-parts

Discrepencies vs spec and `NodeTemplatePart`

Open
#43 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
166
Forks
17
PR merge metrics
No merged PRs in 30d

Description

One other thing I see discrepancy with is missing _NodeValueSetter_ in _NodeTemplatePart_. I get your reasoning - it also seems a bit faster to not have setter and call `splitText` in collecting parts instead of initial replacing with collected parts, but I wonder if `nodePart.replacementNodes` can be useful for processor implementors - it seems to be missing now.
```diff
// NodeTemplatePart
++ get replacementNodes() {
++ return this.#parts
++ }

```

_Originally posted by @dy in https://github.com/github/template-parts/issues/38#issuecomment-1007673129_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.