github / github/pages-gem

Unwanted <p> tag in list item if line break follows

Open
#729 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
1.9k
Forks
360
PR merge metrics
No merged PRs in 30d

Description

# Problem

## Environments Effected

- [x] The site generated by GitHub Pages
- [x] Building sites locally

### Detail

```rb
-* [nodeJS, express, Docker Compose](//github.com/4richardchen/gotenna) - code
-{% for post in site.posts %}{% unless post.tags contains "answer" or post.published == false or post.tags contains 'unanswered' %}
```
yields incorrect markup
```htm

  • nodeJS, express, Docker Compose - code


  • ```
    but then
    ```rb
    * [nodeJS, express, Docker Compose](//github.com/4richardchen/gotenna) - code{% for post in site.posts %}{% unless post.tags contains "answer" or post.published == false or post.tags contains 'unanswered' %}
    ```
    yields correct markup
    ```htm
  • nodeJS, express, Docker Compose - code

  • ```

    ### What did you expect to happen?

    no excess `

    ` tag in markup (_see above_)

    ### What happened instead?

    1 excess `

    ` tag in markup (_see above_)

    ### Additional information

    * Link to the live site: Correct markup now at https://4richardchen.github.io.
    * Link to the source repo: I fixed it in [this commit](https://github.com/4richardchen/4richardchen.github.com/commit/1c9c99fedc240f03b96de08de4306ace70fa81f3) at [this repo](https://github.com/4richardchen/4richardchen.github.com/commits/master).

    Contributor guide

    Open the contributing guide

    Assessment

    This issue has not been assessed yet.

    Get new issues in your inbox

    A short digest of beginner-friendly GitHub issues.