cli programs need -ljansson at end instead of at the beginning
- Dominant language
- C
- Stars
- 2.5k
- Forks
- 239
- PR merge metrics
- No merged PRs in 30d
Description
Not sure which system it was tested on -- libraries generally have to be in order
I'm using ubuntu 18.04 with gcc 7.4
+ ${MAKE} -C src/glb-director/cli clean
diff --git a/src/glb-director/cli/Makefile b/src/glb-director/cli/Makefile
index d7433a7..ecfeeef 100644
--- a/src/glb-director/cli/Makefile
+++ b/src/glb-director/cli/Makefile
@@ -73,44 +73,44 @@ LDFLAGS += -ljansson
glb-director-cli: main.c
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
-I`pwd`/.. \
main.c \
../siphash24.c \
- -o glb-director-cli
+ -o glb-director-cli ${LDFLAGS}
glb-config-check:
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
$(CHECK_SRCS) \
-o glb-config-check \
-I`pwd`/.. \
-I/usr/include/dpdk \
-I/usr/include/x86_64-linux-gnu \
- -ldpdk -lpcap \
+ -ldpdk -lpcap ${LDFLAGS} \
-m64 -mssse3
glb-director-pcap:
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
$(PCAP_SRCS) \
-o glb-director-pcap \
-I`pwd`/.. \
:
- make -C src/glb-healthcheck clean
- make -C src/glb-director clean
- make -C src/glb-director/cli clean
+ ${MAKE} -C src/glb-redirect clean
+ ${MAKE} -C src/glb-healthcheck clean
+ ${MAKE} -C src/glb-director clean
+ ${MAKE} -C src/glb-director/cli clean
diff --git a/src/glb-director/cli/Makefile b/src/glb-director/cli/Makefile
index d7433a7..ecfeeef 100644
--- a/src/glb-director/cli/Makefile
+++ b/src/glb-director/cli/Makefile
@@ -73,44 +73,44 @@ LDFLAGS += -ljansson
glb-director-cli: main.c
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
-I`pwd`/.. \
main.c \
../siphash24.c \
- -o glb-director-cli
+ -o glb-director-cli ${LDFLAGS}
glb-config-check:
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
$(CHECK_SRCS) \
-o glb-config-check \
-I`pwd`/.. \
-I/usr/include/dpdk \
-I/usr/include/x86_64-linux-gnu \
- -ldpdk -lpcap \
+ -ldpdk -lpcap ${LDFLAGS} \
-m64 -mssse3
glb-director-pcap:
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
$(PCAP_SRCS) \
-o glb-director-pcap \
-I`pwd`/.. \
+ -ldpdk -lpcap ${LDFLAGS} \
-m64 -mssse3
glb-director-pcap:
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
$(PCAP_SRCS) \
-o glb-director-pcap \
-I`pwd`/.. \
-I/usr/include/dpdk \
-I/usr/include/x86_64-linux-gnu \
- -lpcap \
- -DPCAP_MODE \
+ -lpcap ${LDFLAGS}
+ -DPCAP_MODE ${CFLAGS} \
-m64 -mssse3
glb-director-stub-server:
gcc \
- $(CFLAGS) $(LDFLAGS) \
+ $(CFLAGS) \
$(STUB_SRCS) \
-o glb-director-stub-server \
-I`pwd`/.. \
-I/usr/include/dpdk \
-I/usr/include/x86_64-linux-gnu \
- -DPCAP_MODE \
+ -DPCAP_MODE ${LDFLAGS} \
-m64 -mssse3
clean:
Contributor guide
Assessment
This issue has not been assessed yet.