github / github/github-ldap

Add support for handling Active Directory member attribute with Range suffix

Open
#98 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
158
Forks
28
PR merge metrics
No merged PRs in 30d

Description

[Depending on a `MaxValRange` setting on an Active Directory server](https://support.microsoft.com/ja-jp/kb/2009267), the server can return the `member;Range=[low]-[high]` (e.g. `member;Range=0-1499`) attribute including certain number of users instead of the `member` attribute including all users when a number of users in a group exceeds the `MaxValRange` value.

Since the filters in the [lib/github/ldap/filter.rb](https://github.com/github/github-ldap/blob/b75ef743fd68c8df51194a56a44db5c009831261/lib/github/ldap/filter.rb#L9) don't care the `member` attribute with the `Range` suffix, no users can be found.

The filter should be able to handle the `member` attribute with the `Range` suffix and also it needs to support pagination if the `Range` suffix exists.

Contributor guide

Open the contributing guide

Research direction

Start in lib/github/ldap/filter.rb around line 9, where the LDAP filters currently handle the member attribute. Reproduce or inspect responses containing a member;Range suffix and determine how ranged results should be paginated. Done means groups exceeding Active Directory's MaxValRange can be searched and all applicable users are found.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
authentication
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.