github / github/gh-ost

Why limit CutOverLockTimeoutSeconds to 10 seconds?

Open
#474 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
13.6k
Forks
1.4k
Avg merge
2h 31m
Merged PRs (30d)
4

Description

There's a command line flag (`-cut-over-lock-timeout-seconds`) which allows you to control how much time to wait for a lock when performing a cutover.

Why is this [limited to 10 seconds](https://github.com/github/gh-ost/blob/5294ab6bd10c36bba7cd37e5739e6cab70b2cfda/go/base/context.go#L341)? Seems like [MySQL defaults to 50 sec](https://dev.mysql.com/doc/refman/5.7/en/innodb-parameters.html#sysvar_innodb_lock_wait_timeout) and allows much larger values.

It would be nice for potentially high-load tables to increase this lock wait timeout. We've had to limit database load temporarily in order to perform cut-overs due to the short lock wait timeout.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.