support `--sql-log-bin` (bool)
Open
enhancement
- Dominant language
- Go
- Stars
- 13.6k
- Forks
- 1.4k
- Avg merge
- 2h 31m
- Merged PRs (30d)
- 4
Description
`--sql-log-bin` would default `true`. When `false`, writes to _ghost_ table will not be logged to binlogs.
This may only work on:
- `--test-on-replica`
- `--migrate-on-replica`
- `--allow-on-master`
This cannot work on normal connect-to-replica-and-write-on-master.
When GTID is enabled such writes would cause errant transactions.
_Note_: the _changelog_ table also gets writes. In the event you're using GTID this still calls for a problem if you're migrating on a replica. See https://github.com/github/gh-ost/issues/146 for more discussion.
Contributor guide
Assessment
This issue has not been assessed yet.