github / github/gh-gei

Modify ExportState in `bbs2gh` so if it treats unexpected values as errors

Open
#724 0 comments 0 reactions 0 assignees View on GitHub
task tech debt
Dominant language
C#
Stars
478
Forks
146
Avg merge
7d 21h
Merged PRs (30d)
2

Description

I managed to get into an infinite loop because I had an invalid value (in this case null), that I was passing to `ExportState.IsInProgress()` and that treats any unexpected value as InProgress. It should treat unexpected values as errors like we do in other similar places in the code. IsInProgress should specifically check for what state value it expects, and treat anything else as error state.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.