[deep-report] Dedup domainAnalysisWireSchema (exact duplicate of domainAnalysisWire)
- Dominant language
- Go
- Stars
- 5.1k
- Forks
- 541
- Avg merge
- 5h 48m
- Merged PRs (30d)
- 773
Description
### Problem
`domainAnalysisWireSchema` in `pkg/cli/mcp_schema.go:270` is an exact structural duplicate of `domainAnalysisWire` in `pkg/cli/access_log.go:44` (with its `MarshalJSON`/`UnmarshalJSON` at lines 55/67). The schema struct exists solely to feed `GenerateOutputSchema[domainAnalysisWireSchema]()` (`pkg/cli/mcp_schema.go:312`), duplicating every field of the wire struct instead of reusing it.
### Why it matters
Two structs must be kept in sync by hand on every field change to `domainAnalysisWire`; a future edit to one and not the other silently desyncs the generated MCP schema from the actual wire format.
### Suggested fix
Reuse `domainAnalysisWire` directly in `GenerateOutputSchema[...]()` (or generate the schema type via a shared type alias) and delete `domainAnalysisWireSchema`.
### Data source
Typist code-quality analysis (Cluster 1), live-verified against current `pkg/cli/access_log.go` and `pkg/cli/mcp_schema.go` in this cycle — no matching open issue found.
**Suggested Agent:** general coding agent (Go)
**Estimated Effort:** Small (single-file mechanical dedup)
> [!WARNING]
>
> Firewall blocked 1 domain
>
> The following domain was blocked by the firewall during workflow execution:
>
> - `api.anthropic.com`
>
> To allow these domains, add them to the `network.allowed` list in your workflow frontmatter:
>
> ```yaml
> network:
> allowed:
> - defaults
> - "api.anthropic.com"
> ```
>
> See [Network Configuration](https://github.github.com/gh-aw/reference/network/) for more information.
>
>
> Generated by [🔬 Deep Report](https://github.com/github/gh-aw/actions/runs/34969464054) · claude · agent · 279.5 AIC · ⌖ 12.7 AIC · ⊞ 12.8K · [◷](https://github.com/search?q=repo%3Agithub%2Fgh-aw+is%3Aissue+%22gh-aw-workflow-call-id%3A+github%2Fgh-aw%2Fdeep-report%22&type=issues)
> - [x] expires on Sep 17, 2026, 4:50 AM UTC-08:00
Contributor guide
Research direction
Start with domainAnalysisWire in pkg/cli/access_log.go and domainAnalysisWireSchema plus GenerateOutputSchema in pkg/cli/mcp_schema.go. Confirm the structs are exact duplicates and inspect the existing MarshalJSON and UnmarshalJSON methods before removing the schema duplicate. Done means the generated MCP schema uses domainAnalysisWire directly and the package still builds and passes its Go checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 86/100