github / github/gh-aw

[windows-integration] Replace direct `gh issue create` in Windows integration conclusion job with safe output compatible issue signaling

Open
#59,882 0 comments 0 reactions 0 assignees View on GitHub
windows workflow
Dominant language
Go
Stars
5.1k
Forks
541
Avg merge
5h 48m
Merged PRs (30d)
773

Description

The workflow `.github/workflows/windows-cli-integration.yml` is mostly aligned with the required behavior (daily schedule + manual trigger, multi-job orchestration, Linux build + artifact upload, Windows matrix/chaos integration checks, timeout/hang detection, and `if: always()` conclusion gating), but it has one critical mismatch for this environment and policy: it creates failure issues via direct `gh issue create` in the workflow.

### Problem
The `conclusion` job currently runs:
- `gh issue create ...`

In this execution model, GitHub writes must use safe-output tooling. Direct `gh` writes are not guaranteed/allowed for this class of automation. This can make failure reporting unreliable right where it is most needed.

### Required update
Update the conclusion issue-creation step in `.github/workflows/windows-cli-integration.yml` to use the repository’s approved write path for issue creation (safe-output-compatible mechanism used by this project’s workflow system), while preserving existing behavior:
- keep `if: always()` conclusion orchestration
- preserve failed-jobs aggregation and explicit final pass/fail exit
- preserve issue content quality (failed jobs + run URL + UTC timestamp)
- keep minimal explicit permissions

### Acceptance criteria
- When `build` or `integration` is non-success, conclusion still fails the workflow.
- A failure issue is created through the approved safe-output path, not direct `gh issue create`.
- Issue body still includes failed jobs and run link for debugging.
- No unrelated workflow behavior changes.

> [!WARNING]
>
> Firewall blocked 1 domain
>
> The following domain was blocked by the firewall during workflow execution:
>
> - `ab.chatgpt.com`
>
> To allow these domains, add them to the `network.allowed` list in your workflow frontmatter:
>
> ```yaml
> network:
> allowed:
> - defaults
> - "ab.chatgpt.com"
> ```
>
> See [Network Configuration](https://github.github.com/gh-aw/reference/network/) for more information.
>
>

> Generated by [🪟 Daily Windows Terminal Integration Builder](https://github.com/github/gh-aw/actions/runs/34438413103) · codex · gpt53codex · 6.2 AIC · ⌖ 2.67 AIC · ⊞ 13.8K · [◷](https://github.com/search?q=repo%3Agithub%2Fgh-aw+is%3Aissue+%22gh-aw-workflow-call-id%3A+github%2Fgh-aw%2Fdaily-windows-terminal-integration-builder%22&type=issues)

Contributor guide

Open the contributing guide

Research direction

Start with .github/workflows/windows-cli-integration.yml and inspect the conclusion job and its current issue-creation step. Search the repository for the approved safe-output issue-signaling pattern, then verify the build and integration failure paths still include failed jobs, the run URL, and the UTC timestamp while preserving always-run orchestration and the final failure status.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.