github / github/gh-aw

[windows-integration] Update windows-cli-integration workflow to use safeoutputs for failure issue creation

Open Beginner friendly
#58,920 0 comments 0 reactions 0 assignees View on GitHub
windows workflow
Dominant language
Go
Stars
5.1k
Forks
541
Avg merge
5h 48m
Merged PRs (30d)
773

Description

The current `.github/workflows/windows-cli-integration.yml` is very close to the required behavior, but one required change is still needed.

### What is missing
The `conclusion` job currently creates failure issues using `gh issue create` with `GH_TOKEN`. In this environment/policy, GitHub writes must use safe-output tooling rather than direct `gh` writes.

### Why this matters
The task requirements explicitly say that if any required job fails, the conclusion job must create a GitHub issue describing failed jobs and linking the run. It already does that content-wise, but the write path should be switched to the approved safe-output mechanism to stay compliant with workflow write constraints.

### Requested update
Please update `.github/workflows/windows-cli-integration.yml` so the `Create failure issue` step uses the approved safe-output write path instead of direct `gh issue create`.

### Acceptance criteria
- Workflow still triggers on `schedule` and `workflow_dispatch`.
- Build runs on `ubuntu-latest`, cross-compiles `gh-aw.exe`, uploads artifact.
- Integration runs on `windows-latest`, downloads artifact, executes matrixed shell/launch/env/path scenarios including hang/timeouts and negative case.
- `conclusion` runs with `if: always()` and aggregates `build` + `integration` results.
- On any failure, conclusion creates an issue containing failed job list and run URL via approved write mechanism (safe outputs), then fails the workflow.
- No unrelated workflow changes.

### Notes
Everything else in the current workflow already aligns well with the requested Windows integration coverage and debugging expectations (timeouts, shell variants, PATH/PATHEXT/path-shape chaos, unicode path handling, and explicit hang detection).

> [!WARNING]
>
> Firewall blocked 1 domain
>
> The following domain was blocked by the firewall during workflow execution:
>
> - `ab.chatgpt.com`
>
> To allow these domains, add them to the `network.allowed` list in your workflow frontmatter:
>
> ```yaml
> network:
> allowed:
> - defaults
> - "ab.chatgpt.com"
> ```
>
> See [Network Configuration](https://github.github.com/gh-aw/reference/network/) for more information.
>
>

> Generated by [🪟 Daily Windows Terminal Integration Builder](https://github.com/github/gh-aw/actions/runs/34012223490) · codex · gpt53codex · 6.47 AIC · ⌖ 2.84 AIC · ⊞ 14.8K · [◷](https://github.com/search?q=repo%3Agithub%2Fgh-aw+is%3Aissue+%22gh-aw-workflow-call-id%3A+github%2Fgh-aw%2Fdaily-windows-terminal-integration-builder%22&type=issues)

Contributor guide

Open the contributing guide

Research direction

Open .github/workflows/windows-cli-integration.yml and inspect the conclusion job's Create failure issue step first. Replace only its direct issue-write path with the approved safe-output mechanism, then verify the schedule and workflow_dispatch triggers, job dependencies, failure handling, and Windows integration matrix remain unchanged; done means failed runs create an issue with the failed jobs and run URL through safe outputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.