github / github/codeql

CodeQL Cli - false positive - Missing Dispose call on local IDisposable on MemoryStream

Open
#7,227 3 comments 0 reactions 0 assignees View on GitHub
acknowledged C# false-positive not security
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**
Error type: Missing Dispose call on local IDisposable

I ran csharp-lgtm-full.qls on my codebase. The result flag out usage of System.IO.MemoryStream class. This class implements IDisposable. However, the documentation says that MemoryStream does not hold on to any resources which needs to be disposed. (https://docs.microsoft.com/en-us/dotnet/api/system.io.memorystream?view=net-6.0)

Code that is flagged
`response.SetupProperty(r => r.Body, new MemoryStream());`

I think this class should be added to ignore list based on the MSDN documentation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.