github / github/codeql

LGTM.com - false positive for move and copy assignment operators not returning *this (C++)

Open
#7,035 2 comments 2 reactions 0 assignees View on GitHub
acknowledged C++ false-positive not security
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

The error is reported for these operators when `*this` is returned indirectly via a function call. For example:

https://lgtm.com/projects/g/oknenavin/cxon/snapshot/9103621a01a81595999681a97870d8930d56aa58/files/src/cxon/lang/cbor/node/node.hxx?sort=name&dir=ASC&mode=heatmap#xc6e83398218bd018:1

we have:
``` c++
return value::move_assign(*this, std::forward(o));
```
where `value::move_assign` returns its first argument, which is `*this`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.