github / github/codeql

Java: `Nullness.unboxed` does not use `ConversionSite`

Open
#5,763 1 comment 0 reactions 0 assignees View on GitHub
Java question
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

The private predicate `unboxed` of `semmle.code.java.dataflow.Nullness` seems to match locations where an implicit conversion from boxed to primitive type occurs:
https://github.com/github/codeql/blob/a7030c7fed4811f63c70d8fe67941f67b045b3aa/java/ql/src/semmle/code/java/dataflow/Nullness.qll#L54

Would it maybe be better to use `ConversionSite` of `semmle.code.java.Conversions` for this to avoid code duplication, or was this done intentionally (for performance reasons)?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.