github / github/codeql

Java: Extractor succeeds despite semmle-extractor-options using invalid `-source` or `-target` values

Open
#5,648 1 comment 0 reactions 0 assignees View on GitHub
bug Java
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

### Version
CodeQL CLI 2.5.0

### Description of the issue
Possibly related to #5594

When using `codeql test run` and an `options` file containing `semmle-extractor-options` with `-source` or `-target` with an invalid value (e.g. `-source 2`; apparently `javac` expects `-source 1.2`) the extractor succeeds despite `javac` reporting errors.

Note that this does not apply to other incorrect argument usage, such as specifying both `--source` and `--release` or using the correct version notation, e.g. `-source 1.2`. In that case the extractor fails, as expected.

### Reproduction steps
1. Create a query test file and a Java source file (content does not matter)
2. Create an `options` file containing:
```
//semmle-extractor-options: --javac-args -source 2
```
3. Run `codeql test run --keep-databases`
:x: The test succeeds (or fails on `RESULT` stage)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.