github / github/codeql

LGTM.com - false positive: "Duplicate HTML element attributes" caused by valid Django template tags

Open
#5,296 0 comments 0 reactions 0 assignees View on GitHub
false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**

```html
{% csrf_token %}
```
This is valid Django template HTML with no duplicate attributes, however LGTM reports it as having duplicate tags due to it seeing `{%` and `%}` appear multiple times in a single opening tag.

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/ArchiveBox/ArchiveBox/snapshot/665e2817780d54eb2e1540fd80e48aeef9950775/files/archivebox/templates/admin/private_index_grid.html#L61

![image](https://user-images.githubusercontent.com/511499/109436156-37c78f00-79ec-11eb-9a8a-7a1f79c9bf0c.png)

**Possibly related PRs/Issues:**

- https://github.com/github/codeql/pull/5236
- https://github.com/github/codeql/issues/5224

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.