github / github/codeql

LGTM.com - false positive: Java Set equals()

Open
#3,524 1 comment 0 reactions 0 assignees View on GitHub
false-positive Java
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**
"Call to equals() comparing incomparable types AbstractSet and ImmutableSet."

This actually works just fine, because AbstractSet and ImmutableSet only use the Set<> interface's semantics, and do not rely on what implementation of Set they are.

**URL to the alert on the project page on LGTM.com**

https://lgtm.com/projects/g/google/error-prone/snapshot/30c381a82e01a40b3f7f255ed05d0857bcf0d35e/files/core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryDefaultInEnumSwitch.java?sort=name&dir=ASC&mode=heatmap#L96

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.