github / github/codeql

False positive in csharp for useless-assignment-to-local

Open
#22,032 1 comment 0 reactions 1 assignee Claimed by @hvitved View on GitHub
false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**

The context is the following: the variable is used inside a lambda and captured by it.

It is not clear to me what the exact cause is. I tried to create a self-contained code sample, but I was not able to trigger the false positive that way, so the sample code relies on AspNetCore, which is the context where I got the warning.

**Code samples or links to source code**

To reproduce, you need a project that depends on AspNetCore, which is possible with a project file like the following: `Sample.csproj`:

```csharp

```

The following is helper code to configure a AspNetCore `WebApplication`:

```csharp
public static class App
{
extension(WebApplication app)
{
public void Configure()
{
string redirectPath = "/app";
app.MapGet("/", () => Results.Redirect(redirectPath));
}
}
}
```

CodeQL complains about the `redirectPath` not being used. The type of the lambda passed to `MapGet` is `Delegate`. An example with self-contained code with a similar setup and the use of a `Delegate` type did not trigger the false positive.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.