github / github/codeql

Python FP when using multiple decorators on class function

Open
#1,902 0 comments 0 reactions 0 assignees View on GitHub
false-positive Python
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

In https://lgtm.com/projects/g/dials/dials/snapshot/5c386da2f97d98b7ec80e34cec0cbf894fce6a36/files/util/filter_reflections.py?sort=name&dir=ASC&mode=heatmap#L288 a function is defined as:
```python
class X:
@staticmethod
@seconddecorator
def function(parameter):
```

Due to the presence of the decorator `@seconddecorator` the type of `parameter` is inferred to be instances of `X`. This is of course not true due to the `@staticmethod` decorator being present.
This can then lead to false positives on operations on `parameter` further down the line.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.