github / github/codeql

Incomplete documentation for cs/web/broad-cookie-domain

Open
#15,169 1 comment 0 reactions 0 assignees View on GitHub
C# documentation
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

I believe the CodeQL documentation here conflicts with MDN by omission:
> In this example cookie1 is accessible from online-bank.com ...
> ```
> HttpCookie cookie1 = new HttpCookie("sessionID");
> cookie1.Domain = "online-bank.com";
> ```

https://codeql.github.com/codeql-query-help/csharp/cs-web-broad-cookie-domain/

According to MDN, that cookie would _also_ be available to subdomains:
> For example, if you set Domain=mozilla.org, cookies are available on mozilla.org and its subdomains like developer.mozilla.org.

https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#domain_attribute

The CodeQL documentation should state that "In this example cookie1 is accessible from online-bank.com _and its subdomains_".

Contributor guide

Open the contributing guide

Research direction

Open the CodeQL documentation page for cs/web/broad-cookie-domain and compare its cookie-domain wording with the linked MDN guidance. Update the example description to mention online-bank.com and its subdomains, then check that the rendered page and references remain accurate.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.