github / github/codeql

cpp/missing-check-scanf: False positive

Open
#12,412 3 comments 0 reactions 0 assignees View on GitHub
acknowledged C++ false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

https://github.com/ryao/zfs/security/code-scanning/420

https://github.com/ryao/zfs/blob/3881dd42bbfb7297f08e796c38b35d54e11ac500/lib/libspl/os/linux/gethostid.c#L50

CodeQL says `This variable is read, but may not have been written. It should be guarded by a check that the returns at least 1.`. However, that is already being done as part of `if (fscanf(f, "%lx", &hostid) != 1)`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.