github / github/auto-complete-element

Dropdown does not close on all blur events

Open
#136 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
407
Forks
57
Avg merge
1d 7h
Merged PRs (30d)
5

Description

We recently moved our application to this library from twitter-typeahead and have run into an issue where the results dropdown will only close when a selection is made. If a user clicks away from the input or tabs to the next form item the dropdown remains open.

This is inconvenient when a value for the field is already set and does not need to be changed. The user accidentally clicks the input or is tabbing through the page and the dropdown opens from the focus event, visually blocking the next form fields until the user makes the selection again.

Is this dropdown behavior intended? If so, could a prop be added so that implementers can turn it on or off?

If it isn't intended behavior, I think changing [this line](https://github.com/github/auto-complete-element/blob/main/src/autocomplete.ts#L250) to `this.interactingWithList = false` or possibly just removing that line altogether would fix things.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.