github / github/app

Logs can fill a disk without any control

Open
#3,597 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
No language data
Stars
2.1k
Forks
157
PR merge metrics
No merged PRs in 30d

Description

Feature summary

An error loop may create a log every ms, ending up filling a disk

What problem are you trying to solve?

This is especially true on chromebook, it is quite random, but sometime when I come back and unlock my session, the process start logging "Audio output stream failed: a backend-specific error has occurred: alsa::poll() returned POLLERR" indefinitly (well unmutting the host sound make this disapears) but anyway the log size increase by 5Gb every minutes meaning the disk is full in a jiffy.

The log file with this issue is "github-app.{pid}.log".

Proposed solution

Would it be possible to limit the size of this file to let say 1Gb and make it rolling (keep 5 file maximum) + an alert "warning rolling log file, check why you have so many logs" .

Workflow impact

no need to clean file to continue working, warning on strange alert if there are.

Installation context

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The affected artifact is github-app.{pid}.log; begin by finding where this file is created and where repeated error output is written. Done means the log is capped at 1 GB, rolls over with at most five files retained, and emits the requested warning when rotation occurs.

Written by the indexing model from the issue text.

Assessment

Domain
desktop, observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.