github / github/app

Search tool results count is off by 1

Open
#3,552 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
No language data
Stars
2.1k
Forks
157
PR merge metrics
No merged PRs in 30d

Description

Short summary

It shows 1 match when there are no matches

Affected version or release

v1.1.14

Installation context

Windows

What happened?

Tool invocations:

Image

Results:

Image

So confusing

Steps to reproduce

See images, searching for a non existing file should show 0 matches instead of 1

Expected behavior

0 matches shown

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the search tool with a non-existent file on Windows and trace where the result count is displayed. The issue names no source files or tests, so locate the search result-count handling from the search tool entry point. Done means an empty search reports 0 matches rather than 1.

Written by the indexing model from the issue text.

Assessment

Domain
desktop, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.