github-vet / github-vet/rangeloop-pointer-findings

kazz187/fargate-td: cmd/fargate-td/cmd/deploy.go; 41 LoC

Open
#9,947 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kazz187/fargate-td](https://www.github.com/kazz187/fargate-td) at [cmd/fargate-td/cmd/deploy.go](https://github.com/kazz187/fargate-td/blob/f761be4195cb8fd6a61a7cab1774075a463eb287/cmd/fargate-td/cmd/deploy.go#L126-L166)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to cluster was used in a composite literal at line 128

[Click here to see the code in its original context.](https://github.com/kazz187/fargate-td/blob/f761be4195cb8fd6a61a7cab1774075a463eb287/cmd/fargate-td/cmd/deploy.go#L126-L166)

Click here to show the 41 line(s) of Go which triggered the analyzer.

```go
for cluster, services := range servicesMap {
svcRes, err := svc.DescribeServicesRequest(&ecs.DescribeServicesInput{
Cluster: &cluster,
Services: services,
}).Send(context.Background())
if err != nil {
return nil, err
}
if svcRes == nil {
return nil, fmt.Errorf("service is not found in cluster %s", cluster)
}
svcToTd := map[string]string{}
for _, s := range svcRes.Services {
svcToTd[*s.ServiceName] = *s.TaskDefinition
}

for _, s := range services {
fmt.Printf("Diff [cluster: %s, service: %s]\n", cluster, s)
td, ok := svcToTd[s]
if !ok {
return nil, fmt.Errorf("service %s is not found in cluster %s", s, cluster)
}
currentTdRes, err := svc.DescribeTaskDefinitionRequest(&ecs.DescribeTaskDefinitionInput{
TaskDefinition: &td,
}).Send(context.Background())
if err != nil {
return nil, fmt.Errorf("failed to get current task definition: %w", err)
}
currentTdRes.TaskDefinition.Revision = newTd.Revision
currentTdRes.TaskDefinition.TaskDefinitionArn = newTd.TaskDefinitionArn
diff := cmp.Diff(currentTdRes.TaskDefinition, newTd)
diffMap[s] = diff
if diff == "" {
fmt.Println("Already up-to-date")
} else {
fmt.Println("```")
displayColorDiff(diff)
fmt.Println("```")
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f761be4195cb8fd6a61a7cab1774075a463eb287

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.