github-vet / github-vet/rangeloop-pointer-findings

ansonmez/ocs_rook: rook/pkg/operator/ceph/cluster/mgr/spec.go; 11 LoC

Open
#9,916 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ansonmez/ocs_rook](https://www.github.com/ansonmez/ocs_rook) at [rook/pkg/operator/ceph/cluster/mgr/spec.go](https://github.com/ansonmez/ocs_rook/blob/4da119158ffe55a9efc9e034bf6036810f791ee2/rook/pkg/operator/ceph/cluster/mgr/spec.go#L145-L155)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/ansonmez/ocs_rook/blob/4da119158ffe55a9efc9e034bf6036810f791ee2/rook/pkg/operator/ceph/cluster/mgr/spec.go#L145-L155)

Click here to show the 11 line(s) of Go which triggered the analyzer.

```go
for _, ver := range []cephver.CephVersion{cephver.Mimic} {
changed, err := client.MgrSetConfig(c.context, c.Namespace, mgrConfig.DaemonID, ver,
fmt.Sprintf("mgr/%s/server_addr", module), "", false)
logger.Infof("clearing http bind fix mod=%s ver=%s changed=%t err=%+v", module, &ver, changed, err)

// this is for the format used in v1.0
// https://github.com/rook/rook/commit/11d318fb2f77a6ac9a8f2b9be42c826d3b4a93c3
changed, err = client.MgrSetConfig(c.context, c.Namespace, mgrConfig.DaemonID, ver,
fmt.Sprintf("mgr/%s/%s/server_addr", module, mgrConfig.DaemonID), "", false)
logger.Infof("clearing http bind fix mod=%s ver=%s changed=%t err=%+v", module, &ver, changed, err)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Infof 5} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 4da119158ffe55a9efc9e034bf6036810f791ee2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.