github-vet / github-vet/rangeloop-pointer-findings

kubermatic/kubermatic: pkg/controller/nodeport-proxy/envoymanager/controller.go; 16 LoC

Open
#9,910 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kubermatic/kubermatic](https://www.github.com/kubermatic/kubermatic) at [pkg/controller/nodeport-proxy/envoymanager/controller.go](https://github.com/kubermatic/kubermatic/blob/46bc5b15a6ef9c91a5067796f07684f028e01804/pkg/controller/nodeport-proxy/envoymanager/controller.go#L136-L151)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 150 passes reference to service to third-party code

[Click here to see the code in its original context.](https://github.com/kubermatic/kubermatic/blob/46bc5b15a6ef9c91a5067796f07684f028e01804/pkg/controller/nodeport-proxy/envoymanager/controller.go#L136-L151)

Click here to show the 16 line(s) of Go which triggered the analyzer.

```go
for _, service := range services.Items {
svcKey := ServiceKey(&service)

ets := extractExposeTypes(&service, r.ExposeAnnotationKey)

// Get associated endpoints
eps := corev1.Endpoints{}
if err := r.Get(context.Background(), types.NamespacedName{Namespace: service.Namespace, Name: service.Name}, &eps); err != nil {
if apierrors.IsNotFound(err) {
continue
}
return errors.Wrap(err, fmt.Sprintf("failed to get endpoints for service '%s'", svcKey))
}
// Add service to the service builder
sb.addService(&service, &eps, ets)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(addService, 3)" -> {"(makeSNIFilterChains, 2)";}
"(makeSNIFilterChains, 2)" -> {}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 46bc5b15a6ef9c91a5067796f07684f028e01804

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.