github-vet / github-vet/rangeloop-pointer-findings

aokumasan/nifcloud-additional-storage-csi-driver: pkg/cloud/cloud.go; 20 LoC

Open
#9,887 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [aokumasan/nifcloud-additional-storage-csi-driver](https://www.github.com/aokumasan/nifcloud-additional-storage-csi-driver) at [pkg/cloud/cloud.go](https://github.com/aokumasan/nifcloud-additional-storage-csi-driver/blob/6c6b232c8ac40262d62cf7445c14fac963070a81/pkg/cloud/cloud.go#L355-L374)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to volume was used in a composite literal at line 372

[Click here to see the code in its original context.](https://github.com/aokumasan/nifcloud-additional-storage-csi-driver/blob/6c6b232c8ac40262d62cf7445c14fac963070a81/pkg/cloud/cloud.go#L355-L374)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, volume := range response.DescribeVolumesOutput.VolumeSet {
// Volume name was setted in volume description.
// So use description to check this volume was created by Kubernetes CSI driver.
if !strings.HasPrefix(nifcloud.StringValue(volume.Description), "pvc-") {
continue
}

volSize, err := strconv.Atoi(nifcloud.StringValue(volume.Size))
if err != nil {
klog.Warningf("could not convert volume size %q. using 100GiB...: %v", nifcloud.StringValue(volume.Size), err)
volSize = 100
}

disks = append(disks, &Disk{
VolumeID: nifcloud.StringValue(volume.VolumeId),
CapacityGiB: int64(volSize),
AvailabilityZone: nifcloud.StringValue(volume.AvailabilityZone),
AttachedInstanceID: getVolumeAttachedInstanceID(&volume),
})
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 6c6b232c8ac40262d62cf7445c14fac963070a81

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.