github-vet / github-vet/rangeloop-pointer-findings
badgerodon/net: rpc/server.go; 39 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [badgerodon/net](https://www.github.com/badgerodon/net) at [rpc/server.go](https://github.com/badgerodon/net/blob/c6f304880568d761b78c3b353ee87d98f36b9a01/rpc/server.go#L68-L106)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable req used in defer or goroutine at line 78
[Click here to see the code in its original context.](https://github.com/badgerodon/net/blob/c6f304880568d761b78c3b353ee87d98f36b9a01/rpc/server.go#L68-L106)
Click here to show the 39 line(s) of Go which triggered the analyzer.
```go
for req := range requests {
s.mu.Lock()
handler, ok := s.handlers[req.Method]
s.mu.Unlock()
go func() {
rw.RLock()
defer rw.RUnlock()
res := Response{
ID: req.ID,
}
if ok {
result := handler(req.Params)
if result != nil {
if err, ok := result.(error); ok {
res.Error = &Error{
Code: 4500,
Message: err.Error(),
}
} else {
bs, err := json.Marshal(result)
if err != nil {
errors <- err
return
}
res.Result = new(json.RawMessage)
*res.Result = json.RawMessage(bs)
}
}
} else {
res.Error = &Error{
Code: 4404,
Message: "unknown method",
}
}
responses <- res
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: c6f304880568d761b78c3b353ee87d98f36b9a01
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.