wmstipes/k8s-rvstore: Advanced Kubernetes/metrics-server/vendor/sigs.k8s.io/structured-merge-diff/typed/merge.go; 28 LoC

Found a possible issue in [wmstipes/k8s-rvstore](https://www.github.com/wmstipes/k8s-rvstore) at [Advanced Kubernetes/metrics-server/vendor/sigs.k8s.io/structured-merge-diff/typed/merge.go](https://github.com/wmstipes/k8s-rvstore/blob/ca7165fd6e93e383535c89493066aac1c0eaa538/Advanced Kubernetes/metrics-server/vendor/sigs.k8s.io/structured-merge-diff/typed/merge.go#L239-L266)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to child is reassigned at line 255

[Click here to see the code in its original context.](https://github.com/wmstipes/k8s-rvstore/blob/ca7165fd6e93e383535c89493066aac1c0eaa538/Advanced Kubernetes/metrics-server/vendor/sigs.k8s.io/structured-merge-diff/typed/merge.go#L239-L266)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for i, child := range lhs.Items {
pe, err := listItemToPathElement(t, i, child)
if err != nil {
errs = append(errs, w.errorf("lhs: element %v: %v", i, err.Error())...)
// If we can't construct the path element, we can't
// even report errors deeper in the schema, so bail on
// this element.
continue
}
keyStr := pe.String()
if _, found := observedLHS[keyStr]; found {
errs = append(errs, w.errorf("lhs: duplicate entries for key %v", keyStr)...)
continue
}
observedLHS[keyStr] = struct{}{}
w2 := w.prepareDescent(pe, t.ElementType)
w2.lhs = &child
if rchild, ok := observedRHS[keyStr]; ok {
w2.rhs = &rchild
}
if newErrs := w2.merge(); len(newErrs) > 0 {
errs = append(errs, newErrs...)
} else if w2.out != nil {
out.Items = append(out.Items, *w2.out)
}
// Keep track of children that have been handled
delete(observedRHS, keyStr)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ca7165fd6e93e383535c89493066aac1c0eaa538