github-vet / github-vet/rangeloop-pointer-findings

vmware-tanzu/velero-plugin-for-vsphere: pkg/utils/utils.go; 13 LoC

Open
#9,809 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [vmware-tanzu/velero-plugin-for-vsphere](https://www.github.com/vmware-tanzu/velero-plugin-for-vsphere) at [pkg/utils/utils.go](https://github.com/vmware-tanzu/velero-plugin-for-vsphere/blob/d2cba53d3b8092ac8562df025688daac06e9bd16/pkg/utils/utils.go#L283-L295)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to item is reassigned at line 284

[Click here to see the code in its original context.](https://github.com/vmware-tanzu/velero-plugin-for-vsphere/blob/d2cba53d3b8092ac8562df025688daac06e9bd16/pkg/utils/utils.go#L283-L295)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for _, item := range backupStorageLocationList.Items {
backupStorageLocation = &item
provider := strings.ToLower(item.Spec.Provider)
if provider != "aws" {
logger.Warnf("RetrieveVSLFromVeleroBSLs: Object store providers, %v, other than AWS are not supported for the moment", provider)
continue
}
region := backupStorageLocation.Spec.Config["region"]
if region == "" {
logger.Warnf("RetrieveVSLFromVeleroBSLs: The region field is missing in the Backup Storage Location. Skiping.")
continue
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: d2cba53d3b8092ac8562df025688daac06e9bd16

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.