github-vet / github-vet/rangeloop-pointer-findings
vmware-tanzu/velero-plugin-for-vsphere: pkg/backuprepository/backup_repository.go; 16 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [vmware-tanzu/velero-plugin-for-vsphere](https://www.github.com/vmware-tanzu/velero-plugin-for-vsphere) at [pkg/backuprepository/backup_repository.go](https://github.com/vmware-tanzu/velero-plugin-for-vsphere/blob/d2cba53d3b8092ac8562df025688daac06e9bd16/pkg/backuprepository/backup_repository.go#L59-L74)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to repositoryClaimItem is reassigned at line 66
[Click here to see the code in its original context.](https://github.com/vmware-tanzu/velero-plugin-for-vsphere/blob/d2cba53d3b8092ac8562df025688daac06e9bd16/pkg/backuprepository/backup_repository.go#L59-L74)
Click here to show the 16 line(s) of Go which triggered the analyzer.
```go
for _, repositoryClaimItem := range brcList.Items {
// Process the BRC only if its they match all the params.
repoMatch := compareBackupRepositoryClaim(repositoryDriver, repositoryParameters, allowedNamespaces, &repositoryClaimItem, logger)
if repoMatch {
if repositoryClaimItem.BackupRepository == "" {
logger.Infof("Found matching BRC for the parameters with no BR reference, BRC: %s", repositoryClaimItem.Name)
logger.Infof("Continuing processing other BRC, the backupdriver is expected to process this BRC later")
brcMap[repositoryClaimItem.Name] = &repositoryClaimItem
} else {
logger.Infof("Found matching BRC for the parameters, BRC: %s", repositoryClaimItem.Name)
// Retrieve the BackupRepository and return.
backupRepositoryNameFound := repositoryClaimItem.BackupRepository
return backupRepositoryNameFound, nil
}
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d2cba53d3b8092ac8562df025688daac06e9bd16
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.