github-vet / github-vet/rangeloop-pointer-findings

rancher/os: cmd/control/install.go; 21 LoC

Open
#9,725 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [rancher/os](https://www.github.com/rancher/os) at [cmd/control/install.go](https://github.com/rancher/os/blob/628e6ab052fca923b73d02ccf173887a2b3bf964/cmd/control/install.go#L693-L713)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable image used in defer or goroutine at line 701

[Click here to see the code in its original context.](https://github.com/rancher/os/blob/628e6ab052fca923b73d02ccf173887a2b3bf964/cmd/control/install.go#L693-L713)

Click here to show the 21 line(s) of Go which triggered the analyzer.

```go
for _, image := range strings.Split(outb.String(), "\n") {
if image == "" {
continue
}
r, w := io.Pipe()
go func() {
// TODO: consider a timeout
// TODO:some of these containers don't have cat / shell
cmd := exec.Command("system-docker", "exec", image, "cat /proc/mount")
cmd.Stdout = w
if err := cmd.Run(); err != nil {
log.Debugf("%s cat %s", image, err)
}
w.Close()
}()
if partitionMounted(device, r) {
err = fmt.Errorf("partition %s mounted in %s, cannot repartition", device, image)
log.Errorf("k? %s", err)
return err
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 628e6ab052fca923b73d02ccf173887a2b3bf964

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.