github-vet / github-vet/rangeloop-pointer-findings
yutuer/jws_go: jws/gamex/modules/city_fish/city_fish_worker.go; 8 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [yutuer/jws_go](https://www.github.com/yutuer/jws_go) at [jws/gamex/modules/city_fish/city_fish_worker.go](https://github.com/yutuer/jws_go/blob/f2dd117e810e22f9e714765a19fc6d6c8065c5ef/jws/gamex/modules/city_fish/city_fish_worker.go#L67-L74)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 72 passes reference to cmd to third-party code
[Click here to see the code in its original context.](https://github.com/yutuer/jws_go/blob/f2dd117e810e22f9e714765a19fc6d6c8065c5ef/jws/gamex/modules/city_fish/city_fish_worker.go#L67-L74)
Click here to show the 8 line(s) of Go which triggered the analyzer.
```go
for cmd := range w.cmd_chan {
func() {
//by YZH 这个让parent never dead, 应该如此吗?
defer logs.PanicCatcherWithInfo("city_fish Worker Panic")
cmd.sid = f.shardId
w.processCommand(&cmd, f.gfs)
}()
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(processCommand, 2)" -> {"(saveChg, 2)";}
"(saveChg, 2)" -> {}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: f2dd117e810e22f9e714765a19fc6d6c8065c5ef
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.