github-vet / github-vet/rangeloop-pointer-findings
ganboing/go-esx: src/net/dnsclient_unix.go; 22 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ganboing/go-esx](https://www.github.com/ganboing/go-esx) at [src/net/dnsclient_unix.go](https://github.com/ganboing/go-esx/blob/ebbe4f8db76b947663cc535602054c84b01b080d/src/net/dnsclient_unix.go#L484-L505)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable fqdn used in defer or goroutine at line 487
[Click here to see the code in its original context.](https://github.com/ganboing/go-esx/blob/ebbe4f8db76b947663cc535602054c84b01b080d/src/net/dnsclient_unix.go#L484-L505)
Click here to show the 22 line(s) of Go which triggered the analyzer.
```go
for _, fqdn := range conf.nameList(name) {
for _, qtype := range qtypes {
go func(qtype uint16) {
_, rrs, err := tryOneName(ctx, conf, fqdn, qtype)
lane <- racer{fqdn, rrs, err}
}(qtype)
}
for range qtypes {
racer := <-lane
if racer.error != nil {
// Prefer error for original name.
if lastErr == nil || racer.fqdn == name+"." {
lastErr = racer.error
}
continue
}
addrs = append(addrs, addrRecordList(racer.rrs)...)
}
if len(addrs) > 0 {
break
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ebbe4f8db76b947663cc535602054c84b01b080d
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.