zbo14/goPBFT: replica.go; 129 LoC

Found a possible issue in [zbo14/goPBFT](https://www.github.com/zbo14/goPBFT) at [replica.go](https://github.com/zbo14/goPBFT/blob/0fa24a91d535cd4a544bd3f0dd0e4009be5e8ac4/replica.go#L1062-L1190)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable summary used in defer or goroutine at line 1099

[Click here to see the code in its original context.](https://github.com/zbo14/goPBFT/blob/0fa24a91d535cd4a544bd3f0dd0e4009be5e8ac4/replica.go#L1062-L1190)

Click here to show the 129 line(s) of Go which triggered the analyzer.

```go
for _, summary := range summaries {

if summary.Sequence != seq {
continue
}

if summary.Digest != nil {

var view uint64

for _, req := range requests {
reqViewChange := req.GetViewchange()
preps := reqViewChange.GetPreps()
for _, prep := range preps {
s := prep.Sequence
d := prep.Digest
if s != summary.Sequence || !pb.EQ(d, summary.Digest) {
continue
}
v := prep.View
if v > view {
view = v
}
}
}

verifiedA1 := make(chan bool, 1)

// Verify A1
go func() {

var A1 []*pb.Request

FOR_LOOP:
for _, req := range requests {
reqViewChange := req.GetViewchange()
s := reqViewChange.Sequence
if s >= summary.Sequence {
continue
}
preps := reqViewChange.GetPreps()
for _, prep := range preps {
s = prep.Sequence
if s != summary.Sequence {
continue
}
d := prep.Digest
v := prep.View
if v > view || (v == view && !pb.EQ(d, summary.Digest)) {
continue FOR_LOOP
}
}
A1 = append(A1, req)
if rep.twoThirds(len(A1)) {
verifiedA1 <- true
return
}
}
verifiedA1 <- false
}()

verifiedA2 := make(chan bool, 1)

// Verify A2
go func() {

var A2 []*pb.Request

for _, req := range requests {
reqViewChange := req.GetViewchange()
prePreps := reqViewChange.GetPrepreps()
for _, prePrep := range prePreps {
s := prePrep.Sequence
d := prePrep.Digest
v := prePrep.View
if s == summary.Sequence && pb.EQ(d, summary.Digest) && v >= view {
A2 = append(A2, req)
break
}
}
if rep.oneThird(len(A2)) {
verifiedA2 <- true
return
}
}
verifiedA2 <- false
}()

if !<-verifiedA1 || !<-verifiedA2 {
continue
}

valid = true
break

} else {

var A1 []*pb.Request

FOR_LOOP:

for _, req := range requests {

reqViewChange := req.GetViewchange()

s := reqViewChange.Sequence

if s >= summary.Sequence {
continue
}

preps := reqViewChange.GetPreps()
for _, prep := range preps {
if prep.Sequence == summary.Sequence {
continue FOR_LOOP
}
}

A1 = append(A1, req)
if rep.twoThirds(len(A1)) {
valid = true
break
}
}
if valid {
break
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 0fa24a91d535cd4a544bd3f0dd0e4009be5e8ac4