techknowlogick/shiori: database/xorm.go; 25 LoC

Found a possible issue in [techknowlogick/shiori](https://www.github.com/techknowlogick/shiori) at [database/xorm.go](https://github.com/techknowlogick/shiori/blob/bdd46bc07b2df7251066579eec41a31bf16932fd/database/xorm.go#L200-L224)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/techknowlogick/shiori/blob/bdd46bc07b2df7251066579eec41a31bf16932fd/database/xorm.go#L200-L224)

Click here to show the 25 line(s) of Go which triggered the analyzer.

```go
for _, bookmark := range bookmarks {
// create bookmark & get ID
session.Where("id = ?", bookmark.ID).Update(&bookmark)
// clear existing tag assignments
session.Where("bookmark_id = ?", bookmark.ID).Delete(&model.BookmarkTag{})
// insert & assign tag assignments
for i := 0; i < len(bookmark.Tags); i++ {
var tag model.Tag
tag.Name = bookmark.Tags[i].Name
has, err := session.Exist(&tag)
if err != nil {
return []model.Bookmark{}, err
}
if !has {
// create tag
session.Insert(&tag)
} else {
session.Where("name = ?", tag.Name).Get(&tag)
}
bookmark.Tags[i] = tag
// add bookmark_tag relation
session.Insert(&model.BookmarkTag{BookmarkID: bookmark.ID, TagID: tag.ID})
}
result = append(result, bookmark)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Update 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bdd46bc07b2df7251066579eec41a31bf16932fd