github-vet / github-vet/rangeloop-pointer-findings

stashapp/stash: pkg/ffmpeg/encoder.go; 20 LoC

Open
#9,304 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [stashapp/stash](https://www.github.com/stashapp/stash) at [pkg/ffmpeg/encoder.go](https://github.com/stashapp/stash/blob/5c10712aab726f5e63aa2421146fce2311bef1e2/pkg/ffmpeg/encoder.go#L63-L82)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable process used in defer or goroutine at line 72

[Click here to see the code in its original context.](https://github.com/stashapp/stash/blob/5c10712aab726f5e63aa2421146fce2311bef1e2/pkg/ffmpeg/encoder.go#L63-L82)

Click here to show the 20 line(s) of Go which triggered the analyzer.

```go
for _, process := range processes {
// assume it worked, don't check for error
fmt.Printf("Killing encoder process for file: %s", path)
process.Kill()

// wait for the process to die before returning
// don't wait more than a few seconds
done := make(chan error)
go func() {
_, err := process.Wait()
done <- err
}()

select {
case <-done:
return
case <-time.After(5 * time.Second):
return
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 5c10712aab726f5e63aa2421146fce2311bef1e2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.