github-vet / github-vet/rangeloop-pointer-findings
blackducksoftware/synopsys-operator: pkg/crdupdater/helpers.go; 26 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [blackducksoftware/synopsys-operator](https://www.github.com/blackducksoftware/synopsys-operator) at [pkg/crdupdater/helpers.go](https://github.com/blackducksoftware/synopsys-operator/blob/5d42de7a920499c0200b65d821af23a7e7afeb66/pkg/crdupdater/helpers.go#L287-L312)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to req is reassigned at line 288
[Click here to see the code in its original context.](https://github.com/blackducksoftware/synopsys-operator/blob/5d42de7a920499c0200b65d821af23a7e7afeb66/pkg/crdupdater/helpers.go#L287-L312)
Click here to show the 26 line(s) of Go which triggered the analyzer.
```go
for idx, req := range oldReqmnts {
oldReq := &req
newReq := &newReqmnts[idx]
oldKey := oldReq.Key
newKey := newReq.Key
log.Debugf("oldKey: %v", oldKey)
log.Debugf("newKey: %v", newKey)
oldOperator := oldReq.Operator
newOperator := newReq.Operator
log.Debugf("oldOperator: %v", oldOperator)
log.Debugf("newOperator: %v", newOperator)
oldValues := oldReq.Values
newValues := newReq.Values
log.Debugf("oldValues: %v", oldValues)
log.Debugf("newValues: %v", newValues)
if !reflect.DeepEqual(oldKey, newKey) && !reflect.DeepEqual(oldOperator, newOperator) && !reflect.DeepEqual(oldValues, newValues) {
return false
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 5d42de7a920499c0200b65d821af23a7e7afeb66
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.