github-vet / github-vet/rangeloop-pointer-findings
ZJUGodwei/K8Srely: src/k8s.io/kubernetes/test/e2e/apps/daemon_set.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ZJUGodwei/K8Srely](https://www.github.com/ZJUGodwei/K8Srely) at [src/k8s.io/kubernetes/test/e2e/apps/daemon_set.go](https://github.com/ZJUGodwei/K8Srely/blob/999c38701ab5232e11a283881b2013cc903db33b/src/k8s.io/kubernetes/test/e2e/apps/daemon_set.go#L728-L741)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/ZJUGodwei/K8Srely/blob/999c38701ab5232e11a283881b2013cc903db33b/src/k8s.io/kubernetes/test/e2e/apps/daemon_set.go#L728-L741)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for _, pod := range pods {
if !metav1.IsControlledBy(&pod, ds) {
continue
}
podImage := pod.Spec.Containers[0].Image
if podImage != image {
allImagesUpdated = false
framework.Logf("Wrong image for pod: %s. Expected: %s, got: %s.", pod.Name, image, podImage)
}
if !podutil.IsPodAvailable(&pod, ds.Spec.MinReadySeconds, metav1.Now()) {
framework.Logf("Pod %s is not available", pod.Name)
unavailablePods++
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {IsControlledBy 2} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 999c38701ab5232e11a283881b2013cc903db33b
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.