github-vet / github-vet/rangeloop-pointer-findings
tonyespy/gxds: service/devices.go; 9 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [tonyespy/gxds](https://www.github.com/tonyespy/gxds) at [service/devices.go](https://github.com/tonyespy/gxds/blob/dbfacd1465a2aef1c8fac3391b4d337322d12947/service/devices.go#L51-L59)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 58 may store a reference to md
[Click here to see the code in its original context.](https://github.com/tonyespy/gxds/blob/dbfacd1465a2aef1c8fac3391b4d337322d12947/service/devices.go#L51-L59)
Click here to show the 9 line(s) of Go which triggered the analyzer.
```go
for _, md := range mDevs {
err = svc.dc.UpdateOpState(md.Id.Hex(), "DISABLED")
if err != nil {
svc.lc.Error(fmt.Sprintf("Update metadata DeviceOpState failed: %s; error: %v", md.Name, err))
}
md.OperatingState = models.OperatingState("DISABLED")
dc.Add(&md)
}
```
Click here to show extra information the analyzer produced.
```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(Add, 1)" -> {"(addDeviceToMetadata, 1)";}
"(addDeviceToMetadata, 1)" -> {}
}
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: dbfacd1465a2aef1c8fac3391b4d337322d12947
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.