github-vet / github-vet/rangeloop-pointer-findings
emef/djv_ads: controller.go; 17 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [emef/djv_ads](https://www.github.com/emef/djv_ads) at [controller.go](https://github.com/emef/djv_ads/blob/b129d3186dfc36fdd7bcea4d21e3c837e738b984/controller.go#L94-L110)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable update used in defer or goroutine at line 101
[Click here to see the code in its original context.](https://github.com/emef/djv_ads/blob/b129d3186dfc36fdd7bcea4d21e3c837e738b984/controller.go#L94-L110)
Click here to show the 17 line(s) of Go which triggered the analyzer.
```go
for _, update := range bidUpdates {
glog.Infof("campaignId=%v bidId=%v prevBid=%v newBid=%v\n",
update.CampaignId, update.BidId, update.PreviousBid, update.NewBid)
if !controller.readOnly {
wg.Add(1)
go func() {
if err := UpdateBid(update.BidId, update.NewBid, rateLimiter); err != nil {
glog.Errorf("Error updating bid: %v\n", err)
}
wg.Done()
}()
}
wg.Wait()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: b129d3186dfc36fdd7bcea4d21e3c837e738b984
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.