github-vet / github-vet/rangeloop-pointer-findings
takihito/go-archer-sync: archer-sync.go; 20 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [takihito/go-archer-sync](https://www.github.com/takihito/go-archer-sync) at [archer-sync.go](https://github.com/takihito/go-archer-sync/blob/c3f12e93833f6d33a813efa678aa38e5fa172cb5/archer-sync.go#L30-L49)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable servers used in defer or goroutine at line 34
[Click here to see the code in its original context.](https://github.com/takihito/go-archer-sync/blob/c3f12e93833f6d33a813efa678aa38e5fa172cb5/archer-sync.go#L30-L49)
Click here to show the 20 line(s) of Go which triggered the analyzer.
```go
for project, servers := range projects {
msg := make(chan string)
parallel := make(chan bool, parallelFlag)
go func() {
for number, target := range servers["servers"] {
select {
case parallel <- true:
go func(n int, server string) {
log.Printf("start deploy. project:%s, server:%s\n", project, server)
result := Rsync(rsyncOption, project, server)
msg <- result
<-parallel
}(number, target)
}
}
}()
for j := 0; j < len(servers["servers"]); j++ {
log.Printf("result\n%s\n", <-msg)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: c3f12e93833f6d33a813efa678aa38e5fa172cb5
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.