github-vet / github-vet/rangeloop-pointer-findings

x-tool/odm: module/dialect/postgresql/dialect_postgre.go; 37 LoC

Open
#8,660 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [x-tool/odm](https://www.github.com/x-tool/odm) at [module/dialect/postgresql/dialect_postgre.go](https://github.com/x-tool/odm/blob/ff315e3fdaea954aa9c5544e73f54fe78ae4d5e2/module/dialect/postgresql/dialect_postgre.go#L142-L178)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable col used in defer or goroutine at line 148

[Click here to see the code in its original context.](https://github.com/x-tool/odm/blob/ff315e3fdaea954aa9c5544e73f54fe78ae4d5e2/module/dialect/postgresql/dialect_postgre.go#L142-L178)

Click here to show the 37 line(s) of Go which triggered the analyzer.

```go
for _, col := range colLst {
syncLock.Add(1)
go func(*core.Col) {
defer syncLock.Done()
var sql string
var colFields string
colName := col.Name()
fieldLst := col.GetRootFields()
var fieldStringLst []string
//output field name and typestr in colFields
for _, field := range fieldLst {
fieldKind := kindToString(field.Kind())
name := field.Name()
// add field's constraints
var constraints string
if field.NotNull() {
constraints = "NOT NULL"
}
has := field.HasDefault()
if has {
reflectV := reflect.Indirect(reflect.ValueOf(field.DefaultValue()))
_v := valueToString(field, &reflectV)
constraints = fmt.Sprintf("%v Default %v", constraints, _v)
}

fieldStringLst = append(fieldStringLst, fmt.Sprintf("%v %v %v", name, fieldKind, constraints))
}

colFields = tool.JoinStringWithComma(fieldStringLst)
// make sql
sql = fmt.Sprintf("CREATE TABLE %s ( %s ) ", colName, colFields)
err := d.Open(sql, nil)
if err != nil {
tool.Panic("DB", err)
}
}(col)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ff315e3fdaea954aa9c5544e73f54fe78ae4d5e2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.