github-vet / github-vet/rangeloop-pointer-findings

sandromello/auto-tls-example: cmd/server/main.go; 28 LoC

Open
#8,467 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sandromello/auto-tls-example](https://www.github.com/sandromello/auto-tls-example) at [cmd/server/main.go](https://github.com/sandromello/auto-tls-example/blob/55efd24bf790412a8c07711d8d0b2692cb05b419/cmd/server/main.go#L221-L248)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to item is reassigned at line 242

[Click here to see the code in its original context.](https://github.com/sandromello/auto-tls-example/blob/55efd24bf790412a8c07711d8d0b2692cb05b419/cmd/server/main.go#L221-L248)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for _, item := range csrList.Items {
if len(item.Status.Certificate) == 0 {
log.Infof("csr=%s - found a pending certificate, it will block until it's processed ...", item.Name)
hasPendingCertificates = true
break
}
log.Infof("csr=%s - found a certificate", item.Name)
block, _ := pem.Decode(item.Status.Certificate)
if block == nil {
log.Warningf("failed decoding, certificate is invalid or empty: %v", string(item.Status.Certificate))
continue
}
crt, err := x509.ParseCertificate(block.Bytes)
if err != nil {
log.Warningf("failed parsing certificate: %v", err)
continue
}
check := time.Now().UTC()
log.Infof("csr=%s, notbefore=%s, notafter=%s", item.Name, crt.NotBefore, crt.NotAfter)
if check.After(crt.NotBefore) && check.Before(crt.NotAfter) {
log.Infof("csr=%s - certificate valid", item.Name)
csr = &item
// turn off because it found a valid one
hasPendingCertificates = false
break
}
log.Infof("csr=%s - certificate expired, moving to the next one ...", item.Name)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 55efd24bf790412a8c07711d8d0b2692cb05b419

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.